Fix #74, add payload submember for all cmd/tlm #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "Payload" submember to all cmd/tlm structs. The message content is found in this sub-structure. This matches the patterns currently implemented in CFE.
jphickey
force-pushed
the
fix-74-payload-substruct
branch
from
d74e0f0
to
ecfb051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a "Payload" submember to all cmd/tlm structs. The message content is found in this sub-structure. This matches the patterns currently implemented in CFE.
Fixes #74
Testing performed
Build and run all tests
Expected behavior changes
None expected. This may affect the padding in some circumstances, but should not change anything if the headers were properly aligned to begin with.
System(s) tested on
Debian
Additional context
This pattern of using a payload sub-structure matches CFE and keeps things more consistent.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.