Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All CMD/TLM message should put content in a "Payload" sub-structure #74

Closed
3 tasks done
jphickey opened this issue Jan 24, 2023 · 0 comments · Fixed by #83
Closed
3 tasks done

All CMD/TLM message should put content in a "Payload" sub-structure #74

jphickey opened this issue Jan 24, 2023 · 0 comments · Fixed by #83
Assignees
@jphickey
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
To match the patterns used in CFE and other modules, all CMD/TLM message definitions should put the content (non-header) parts into a separate struct called "Payload".

Describe the solution you'd like
Separate message content into a sub structure called "Payload".

Additional context
This is benefit to tooling that can use the presence of this field to identify where the actual content starts (e.g. something like offsetof(MsgType, Payload) would work and be correct, as opposed to checking sizeof(CFE_MSG_CommandHeader_t) which may not actually reflect where the content starts due to possible compiler-added padding between them).

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jan 24, 2023
jphickey added a commit to jphickey/FM that referenced this issue Feb 13, 2023
@jphickey
Fix nasa#74, add payload submember for all cmd/tlm
d74e0f0 
Adds a "Payload" submember to all cmd/tlm structs.  The message content
is found in this sub-structure.  This matches the patterns currently
implemented in CFE.
@jphickey jphickey mentioned this issue Feb 13, 2023
Merged
2 tasks
jphickey added a commit to jphickey/FM that referenced this issue Feb 13, 2023
@jphickey
Fix nasa#74, add payload submember for all cmd/tlm
ecfb051 
Adds a "Payload" submember to all cmd/tlm structs.  The message content
is found in this sub-structure.  This matches the patterns currently
implemented in CFE.
dzbaker added a commit that referenced this issue Feb 23, 2023
@dzbaker
Merge pull request #83 from jphickey/fix-74-payload-substruct
2be3511 
Fix #74, add payload submember for all cmd/tlm
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #74, add payload submember for all cmd/tlm jphickey/FM
3 participants
@dzbaker @jphickey @dmknutsen