Fix #221, Move cf_tbldefs.h to src #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves cf_tbldefs.h so that the compiler doesn't pick up the default platform_inc headers instead of the overridden headers (if they exist) at the mission level. The table structure definitions are not configurable at a platfrom level, much like the majority of other applications.
skliper
added
the
CCB:Ready
|
Ping @jhnphm |
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-04-06 APROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
cf_tbldefs.hin platform_inc directory #221Moves cf_tbldefs.h so that the compiler doesn't pick up
the default platform_inc headers instead of the overridden
headers (if they exist) at the mission level. The
table structure definitions are not configurable at a
platfrom level, much like the majority of other
applications.
Testing performed
Build/run unit tests
Expected behavior changes
Overridden headers at mission level will now be used by cf_tbldefs.h vs the defaults in fsw/platform_inc where the file was formerly co-located.
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC