-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic "cf_msgids.h" file that uses offsets from base MID #297
Labels
Comments
jphickey
added a commit
to jphickey/CF
that referenced
this issue
Aug 2, 2022
Define the CF msgids as an offset from the CFE_PLATFORM_CMD_MID_BASE or CFE_PLATFORM_TLM_MID_BASE, which helps simplify configuration. Users should add MSG offsets to the global mission config header.
In theory you could just override as documented in nasa/cFS#403 |
jphickey
added a commit
to jphickey/CF
that referenced
this issue
Dec 13, 2023
Define CF MsgIDs based on TopicID
2 tasks
jphickey
added a commit
to jphickey/CF
that referenced
this issue
Dec 13, 2023
Define CF MsgIDs based on TopicID
dmknutsen
added a commit
that referenced
this issue
Dec 15, 2023
Fix #297, use TopicID for MsgID assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
Currently, the example
cf_msgids.h
file supplied with CF (under platform_inc) is hardcoded, e.g.:CF/fsw/platform_inc/cf_msgids.h
Line 33 in 557c132
This presents some challenges for the user:
Describe the solution you'd like
Use offsets from
CFE_PLATFORM_CMD_MID_BASE
andCFE_PLATFORM_TLM_MID_BASE
like CFE framework does. For example:https://github.com/nasa/cFE/blob/924b2be20a39f17355861396273856caccc8c89f/cmake/sample_defs/cpu1_msgids.h#L87
Thus the user only needs to specify the offset from the base (aka the "topic ID") in the mission_cfg.h file (which has global scope, not processor scope) and each CPU will automatically get non-overlapping MID numbers.
Describe alternatives you've considered
The alternative is to employ the
generate_config_includefile
cmake function to allow the user to specify this file per arch, but IMO the topicID/offset approach is simpler and more logical.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: