Skip to content

Commit

Permalink
Merge pull request #250 from skliper/fix249-ut_coverage_variability
Browse files Browse the repository at this point in the history 
Fix #249, Resolve UT variable coverage results
  • Loading branch information
@astrogeco
astrogeco authored May 31, 2022
2 parents f6ff03b + cfb2046 commit f713109
Showing 1 changed file with 24 additions and 108 deletions.
132 changes: 24 additions & 108 deletions unit-test/cf_chunk_tests.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1075,107 +1075,36 @@ void Test_CF_Chunks_CombineNext_Given_i_IsEqToGiven_chunks_count_ReplaceEverythi
**
*******************************************************************************/

void Test_CF_Chunks_FindSmallestSize_Given_chunks_IsEmptyReturn_0(void)
void Test_CF_Chunks_FindSmallestSize(void)
{
/* Arrange */
CF_ChunkList_t dummy_chunks;
CF_ChunkList_t *arg_chunks = &dummy_chunks;
CF_ChunkIdx_t local_result;

arg_chunks->count = 0;

/* Act */
local_result = CF_Chunks_FindSmallestSize(arg_chunks);

/* Assert */
UtAssert_UINT32_EQ(local_result, 0);
} /* end Test_CF_Chunks_FindSmallestSize_Given_chunks_IsEmptyReturn_0 */

void Test_CF_Chunks_FindSmallestSize_Given_chunks_HasOneChunkReturn_0(void)
{
/* Arrange */
CF_Chunk_t initial_chunks[1] = {{0}};
CF_ChunkList_t dummy_chunks;
CF_ChunkList_t *arg_chunks = &dummy_chunks;
CF_ChunkIdx_t local_result;

initial_chunks[0].size = Any_uint32();

arg_chunks->count = 1;
arg_chunks->chunks = initial_chunks;

/* Act */
local_result = CF_Chunks_FindSmallestSize(arg_chunks);

/* Assert */
UtAssert_UINT32_EQ(local_result, 0);
} /* end Test_CF_Chunks_FindSmallestSize_Given_chunks_HasOneChunkReturn_0 */

void Test_CF_Chunks_FindSmallestSize_Given_chunks_HasTwoChunksReturnsCorrectIndexOfSmallest(void)
{
/* Arrange */
CF_Chunk_t initial_chunks[2] = {{0}};
CF_ChunkList_t dummy_chunks;
CF_ChunkList_t *arg_chunks = &dummy_chunks;
CF_ChunkIdx_t expected_result;
CF_ChunkIdx_t local_result;

initial_chunks[0].size = Any_uint32_Except(0);
initial_chunks[1].size = Any_uint32_Except(initial_chunks[0].size);

if (initial_chunks[0].size < initial_chunks[1].size)
{
expected_result = 0;
}
else
{
expected_result = 1;
}

arg_chunks->count = 2;
arg_chunks->chunks = initial_chunks;
CF_Chunk_t chunk[4];
CF_ChunkList_t chunk_list;

/* Act */
local_result = CF_Chunks_FindSmallestSize(arg_chunks);
memset(chunk, 0, sizeof(chunk));
memset(&chunk_list, 0, sizeof(chunk_list));

/* Assert */
UtAssert_UINT32_EQ(local_result, expected_result);
} /* end Test_CF_Chunks_FindSmallestSize_Given_chunks_HasTwoChunksReturnsCorrectIndexOfSmallest */
/* Set up values */
chunk_list.chunks = chunk;
chunk[0].size = 3;
chunk[1].size = 4;
chunk[2].size = 2;
chunk[3].size = 2;

void Test_CF_Chunks_FindSmallestSize_Given_chunks_HasManyChunksReturnsCorrectIndexOfSmallest(void)
{
/* Arrange */
uint8 dummy_count = 25;
CF_Chunk_t initial_chunks[25] = {{0}}; /* 25 for initial_chunks is arbitrary, small for speed */
CF_ChunkList_t dummy_chunks;
CF_ChunkList_t *arg_chunks = &dummy_chunks;
CF_ChunkIdx_t expected_result = Any_uint8_LessThan(25);
CF_ChunkIdx_t local_result;
uint8 i = 0;
/* chunk_list->count == 0 returns 0 */
UtAssert_UINT32_EQ(CF_Chunks_FindSmallestSize(&chunk_list), 0);

for (i = 0; i < dummy_count; ++i)
{
if (i != expected_result)
{
initial_chunks[i].size =
Any_uint32_GreaterThan(100); /* 100 is arbitrary, a number so we can select a smallest under it */
}
else
{
initial_chunks[i].size =
Any_uint32_LessThan(100); /* 100 is arbitrary, a number so we can select a smallest under it */
}
}
chunk_list.count = 1;
UtAssert_UINT32_EQ(CF_Chunks_FindSmallestSize(&chunk_list), 0);

arg_chunks->count = dummy_count;
arg_chunks->chunks = initial_chunks;
chunk_list.count = 2;
UtAssert_UINT32_EQ(CF_Chunks_FindSmallestSize(&chunk_list), 0);

/* Act */
local_result = CF_Chunks_FindSmallestSize(arg_chunks);
chunk_list.count = 3;
UtAssert_UINT32_EQ(CF_Chunks_FindSmallestSize(&chunk_list), 2);

/* Assert */
UtAssert_UINT32_EQ(local_result, expected_result);
} /* end Test_CF_Chunks_FindSmallestSize_Given_chunks_HasManyChunksReturnsCorrectIndexOfSmallest */
chunk_list.count = 4;
UtAssert_UINT32_EQ(CF_Chunks_FindSmallestSize(&chunk_list), 2);
}

/* end CF_Chunks_FindSmallestSize tests */

Expand Down Expand Up @@ -2334,20 +2263,6 @@ void add_CF_Chunks_CombineNext_tests(void)
"EraseRange_ThenReturn_1");
} /* end add_CF_Chunks_CombineNext_tests */

void add_CF_Chunks_FindSmallestSize_tests(void)
{
UtTest_Add(Test_CF_Chunks_FindSmallestSize_Given_chunks_IsEmptyReturn_0, cf_chunk_tests_Setup,
cf_chunk_tests_Teardown, "Test_CF_Chunks_FindSmallestSize_Given_chunks_IsEmptyReturn_0");
UtTest_Add(Test_CF_Chunks_FindSmallestSize_Given_chunks_HasOneChunkReturn_0, cf_chunk_tests_Setup,
cf_chunk_tests_Teardown, "Test_CF_Chunks_FindSmallestSize_Given_chunks_HasOneChunkReturn_0");
UtTest_Add(Test_CF_Chunks_FindSmallestSize_Given_chunks_HasTwoChunksReturnsCorrectIndexOfSmallest,
cf_chunk_tests_Setup, cf_chunk_tests_Teardown,
"Test_CF_Chunks_FindSmallestSize_Given_chunks_HasTwoChunksReturnsCorrectIndexOfSmallest");
UtTest_Add(Test_CF_Chunks_FindSmallestSize_Given_chunks_HasManyChunksReturnsCorrectIndexOfSmallest,
cf_chunk_tests_Setup, cf_chunk_tests_Teardown,
"Test_CF_Chunks_FindSmallestSize_Given_chunks_HasManyChunksReturnsCorrectIndexOfSmallest");
} /* end add_CF_Chunks_FindSmallestSize_tests */

void add_CF_Chunks_Insert_tests(void)
{
UtTest_Add(
Expand Down Expand Up @@ -2519,7 +2434,8 @@ void UtTest_Setup(void)

add_CF_Chunks_CombineNext_tests();

add_CF_Chunks_FindSmallestSize_tests();
UtTest_Add(Test_CF_Chunks_FindSmallestSize, cf_chunk_tests_Setup, cf_chunk_tests_Teardown,
"Test_CF_Chunks_FindSmallestSize");

add_CF_Chunks_Insert_tests();

Expand Down

0 comments on commit f713109

Please sign in to comment.