test: Add cudf_constructor to conftest
#797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
cudf_constructor to conftestcudf_constructor to conftest
MarcoGorelli
commented
Aug 15, 2024
Comment on lines
-224
to
+226
| import numpy as np # ignore-banned-import | ||
|
|
||
| ser = self._native_series | ||
| res = np.flatnonzero(ser) | ||
| return self._from_native_series( | ||
| native_series_from_iterable( | ||
| res, | ||
| name=self.name, | ||
| index=range(len(res)), | ||
| implementation=self._implementation, | ||
| ) | ||
| ) | ||
| result = ser.__class__(range(len(ser)), name=ser.name, index=ser.index).loc[ser] | ||
| return self._from_native_series(result) |
There was a problem hiding this comment.
np.flatnonzero doesn't play well with cudf - but it's actually not too bad to keep it dataframe-native 😎
MarcoGorelli
commented
Aug 15, 2024
Comment on lines
+200
to
+203
| if implementation is Implementation.CUDF: # pragma: no cover | ||
| obj = obj.copy(deep=False) # type: ignore[attr-defined] | ||
| obj.index = index # type: ignore[attr-defined] | ||
| return obj |
There was a problem hiding this comment.
cudf.Series doesn't have set_axis wtf
|
Damn that's a lot of red appearing in the notebook 🥲 |
|
😄 we'll get there - support is strong enough that use cases like Altair work, but if we expect people to do gradually more complex things with Narwhals, we should address this We'll get there, I think there's a small root cause that's causing many failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cudf.DataFrame if installed
We can't test it in CI (unless Nvidia sponsors us 😉 ), but we can at least run the tests manually on Kaggle notebooks once every whenever we feel like it, like this: https://www.kaggle.com/code/marcogorelli/testing-cudf-in-narwhals/notebook
Gradually fixing up the failing cuDF tests can then make for good sprint material - we're got a few coming up
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.