enh: pandas-like semi join #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated 😭 |
MarcoGorelli
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Yessssss love semi-joins, amazing stuff @FBruzzesi !
Minor comment - hopefully CI is more robust after #456
tests/frame/test_common.py
Outdated
| (["a", "b"], (nw.col("b") < 5), {"a": [1, 3], "b": [4, 4], "z": [7, 8]}), | ||
| ], | ||
| ) | ||
| def test_semi_join( |
There was a problem hiding this comment.
as this is a new test, could we use the constructor fixture for this one, and maybe create a new tests/frame/join_test file that we can later migrate the join tests to?
|
@MarcoGorelli we have another random attacker!
|
MarcoGorelli
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
amazing, feel free to merge if you're happy with it!
we should ignore the
FAILED tests/frame/schema_test.py::test_dtypes - DeprecationWarning: Passing a BlockManager to DataFrame is deprecated and will raise in a future version. Use public APIs instead.
warning in pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below.
Disclaimer: I think I never used a semi join before. From the polars docs this seems like it should do the trick 😁