-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use fastpath in DataFrame.to_numpy
for pandas, improve performance for DataFrame.schema
for pandas, use fewer values to sniff dtype for pandas objects
#1929
Merged
MarcoGorelli
merged 21 commits into
narwhals-dev:main
from
MarcoGorelli:object-as-string
Feb 5, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataFrame.to_numpy
for pandas, improve performance for DataFrame.schema
for pandas, use fewer values to sniff dtype for pandas objects
This comment was marked as outdated.
This comment was marked as outdated.
721249a
to
f2c4004
Compare
FBruzzesi
reviewed
Feb 4, 2025
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
β¦nto object-as-string
β¦i/narwhals into object-as-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should help with unit8co/darts#2661
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below