Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update cudf xfails based on latest version #1250

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/expr_and_series/dt/datetime_attributes_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_datetime_chained_attributes(
def test_to_date(request: pytest.FixtureRequest, constructor: Constructor) -> None:
if any(
x in str(constructor)
for x in ("pandas_constructor", "pandas_nullable_constructor")
for x in ("pandas_constructor", "pandas_nullable_constructor", "cudf")
):
request.applymarker(pytest.mark.xfail)
dates = {"a": [datetime(2001, 1, 1), None, datetime(2001, 1, 3)]}
Expand Down
1 change: 0 additions & 1 deletion tests/expr_and_series/dt/timestamp_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def test_timestamp_datetimes_tz_aware(
(any(x in str(constructor) for x in ("pyarrow",)) and is_windows())
or ("pandas_pyarrow" in str(constructor) and PANDAS_VERSION < (2,))
or ("pyarrow_table" in str(constructor) and PYARROW_VERSION < (12,))
or ("cudf" in str(constructor))
):
request.applymarker(pytest.mark.xfail)
if "pandas_pyarrow" in str(constructor) and PANDAS_VERSION < (
Expand Down
7 changes: 6 additions & 1 deletion tests/translate/to_py_scalar_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@
],
)
def test_to_py_scalar(
constructor_eager: ConstructorEager, input_value: Any, expected: Any
constructor_eager: ConstructorEager,
input_value: Any,
expected: Any,
request: pytest.FixtureRequest,
) -> None:
if isinstance(input_value, bytes) and "cudf" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)
df = nw.from_native(constructor_eager({"a": [input_value]}))
output = nw.to_py_scalar(df["a"].item(0))
if expected == 1 and constructor_eager.__name__.startswith("pandas"):
Expand Down
Loading