Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make module versions as constants for use in tests #1235

Conversation

AlessandroMiola
Copy link
Contributor

@AlessandroMiola AlessandroMiola commented Oct 21, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Makes module versions available as fixtures constants (no need to build fixtures out of them) for use in tests (so that we can avoid specifying parse_version(pd.__version__) and similar).

tests/conftest.py Outdated Show resolved Hide resolved
@AlessandroMiola AlessandroMiola changed the title chore: make module versions as fixtures for use in tests chore: make module versions as constants for use in tests Oct 21, 2024
@AlessandroMiola AlessandroMiola marked this pull request as ready for review October 21, 2024 15:45
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's quite a satisfying diff - thanks @AlessandroMiola !

@MarcoGorelli MarcoGorelli merged commit 220b9fa into narwhals-dev:main Oct 21, 2024
29 checks passed
@AlessandroMiola AlessandroMiola deleted the pkg-versions-as-constants-for-tests branch October 22, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: make PANDAS_VERSION, PYARROW_VERSION, POLARS_VERSION etc constants for tests
2 participants