-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: nox doctests only in Python 3.12 #1222
Conversation
>>> func(df_pd) # doctest:+SKIP | ||
>>> func(df_pl) # doctest:+SKIP | ||
>>> func(df_pa) # doctest:+SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will create a foo.parquet
locally. If we don't want to skip them, I'll add the file to .gitignore
what do you think? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would opt for skipping those! Nice catch π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @EdAbati π
>>> func(df_pd) # doctest:+SKIP | ||
>>> func(df_pl) # doctest:+SKIP | ||
>>> func(df_pa) # doctest:+SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would opt for skipping those! Nice catch π
thanks both! |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
To be consistent with CI #1189 we should just run doctests in Python 3.12 in
nox