chore: nox doctests only in Python 3.12 #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAbati
commented
Oct 18, 2024
Comment on lines
+585
to
+587
| >>> func(df_pd) # doctest:+SKIP | ||
| >>> func(df_pl) # doctest:+SKIP | ||
| >>> func(df_pa) # doctest:+SKIP |
There was a problem hiding this comment.
these will create a foo.parquet locally. If we don't want to skip them, I'll add the file to .gitignore
what do you think? :)
There was a problem hiding this comment.
I would opt for skipping those! Nice catch 👌
FBruzzesi
approved these changes
Oct 18, 2024
Comment on lines
+585
to
+587
| >>> func(df_pd) # doctest:+SKIP | ||
| >>> func(df_pl) # doctest:+SKIP | ||
| >>> func(df_pa) # doctest:+SKIP |
There was a problem hiding this comment.
I would opt for skipping those! Nice catch 👌
|
thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
To be consistent with CI #1189 we should just run doctests in Python 3.12 in
nox