docs: Pyarrow example docstrings for Expr and stable v1 API
#1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
EdAbati
reviewed
Oct 19, 2024
There was a problem hiding this comment.
Thank you for the effort! :)
It all looks great to me, I just suggested to add a couple of comments for consistency with polars.
Tests being green makes confindent to approve, but because of the size of the PR, I'd wait a bit for another review before merging (I may have missed something)
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
FBruzzesi
approved these changes
Oct 20, 2024
MarcoGorelli
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
thanks @CarloLepelaars , and thanks @EdAbati for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
PyArrow docstring examples for
narwhals/expr.pyandnarwhals/stable/v1/__init__.py.I know #1000 mentions to do 4 functions in 1 PR, but was in a good flow so did the full
expr.py. 😊 I think it's still within reason for review.