-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Pyarrow example docstrings for Expr
and stable v1 API
#1218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort! :)
It all looks great to me, I just suggested to add a couple of comments for consistency with polars.
Tests being green makes confindent to approve, but because of the size of the PR, I'd wait a bit for another review before merging (I may have missed something)
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow crazy effort! Thanks a ton for this one! I skimmed through it without noticing anything wrong, and also trust the doctests 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @CarloLepelaars , and thanks @EdAbati for reviewing!
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
PyArrow docstring examples for
narwhals/expr.py
andnarwhals/stable/v1/__init__.py
.I know #1000 mentions to do 4 functions in 1 PR, but was in a good flow so did the full
expr.py
. 😊 I think it's still within reason for review.