Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix pyarrow to_date #1216

Merged
merged 1 commit into from
Oct 18, 2024
Merged

bug: fix pyarrow to_date #1216

merged 1 commit into from
Oct 18, 2024

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Oct 18, 2024

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@raisadz raisadz marked this pull request as ready for review October 18, 2024 08:16
MarcoGorelli
MarcoGorelli approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @raisadz

WhatsApp Image 2024-10-17 at 19 24 47_e4811e59

@MarcoGorelli MarcoGorelli merged commit 8e5cc66 into narwhals-dev:main Oct 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raisadz @MarcoGorelli