feat: add ConstructorEager type

[lucianosrp]

What type of PR is this? (check all applicable)

• 💾 Refactor
• ✨ Feature
• 🐛 Bug Fix
• 🔧 Optimization
• 📝 Documentation
• ✅ Test
• 🐳 Other

Related issues

• Related issue #
• Closes chore: type constructor_eager as ConstructorEager instead of Constructor #1013

Checklist

• Code follows style guide (ruff)
• Tests added
• Documented the changes

If you have comments or can explain your changes, please do so below.

[lucianosrp]

Getting some issues with type checking.

tests/expr_and_series/sort_test.py:30: error: Item "NativeFrame" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]
tests/expr_and_series/sort_test.py:30: error: Item "DataFrame[Any]" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]
tests/expr_and_series/sort_test.py:30: error: Item "DataFrameLike" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]

Should I also add equals to the NativeFrame protocol?

EDIT:
I ended up removing the typehint on sort_test.py:30 as I don't think any dataframe would have the equals method (?)

[lucianosrp]

Not sure how to handle the mypy failure on interchange_to_arrow_test and interchange_schema_test this time.
@FBruzzesi , perhaps you could have a look? I am sure I am missing something very obvious haha

Solved

[MarcoGorelli]

thanks @lucianosrp ! just a comment, but I think the rest is fine

[MarcoGorelli]

I don't think we should be modifying this

[MarcoGorelli]

Getting some issues with type checking.

tests/expr_and_series/sort_test.py:30: error: Item "NativeFrame" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]
tests/expr_and_series/sort_test.py:30: error: Item "DataFrame[Any]" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]
tests/expr_and_series/sort_test.py:30: error: Item "DataFrameLike" of "NativeFrame | DataFrame[Any] | DataFrameLike" has no attribute "equals"  [union-attr]

Should I also add equals to the NativeFrame protocol?

EDIT: I ended up removing the typehint on sort_test.py:30 as I don't think any dataframe would have the equals method (?)

I think you can rewrite the test as follows:

    result = (
        df.select(
            "a",
            nw.col("b").sort(descending=descending, nulls_last=nulls_last),
        )
    )
    compare_dicts(result, expected)

[lucianosrp]

This has been stale for a while. I'll try to make it right this weekend 🔥

[MarcoGorelli]

awesome, thanks @lucianosrp !

[lucianosrp]

Many thanks @MarcoGorelli ! I will merge it now🎉