test: update cudf xfails based on latest version (#1250)

narwhals-dev · Oct 25, 2024 · 21c20f8 · 21c20f8
1 parent 16cff72
commit 21c20f8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/tests/expr_and_series/dt/datetime_attributes_test.py b/tests/expr_and_series/dt/datetime_attributes_test.py
@@ -109,7 +109,7 @@ def test_datetime_chained_attributes(
 def test_to_date(request: pytest.FixtureRequest, constructor: Constructor) -> None:
     if any(
         x in str(constructor)
-        for x in ("pandas_constructor", "pandas_nullable_constructor")
+        for x in ("pandas_constructor", "pandas_nullable_constructor", "cudf")
     ):
         request.applymarker(pytest.mark.xfail)
     dates = {"a": [datetime(2001, 1, 1), None, datetime(2001, 1, 3)]}

diff --git a/tests/expr_and_series/dt/timestamp_test.py b/tests/expr_and_series/dt/timestamp_test.py
@@ -93,7 +93,6 @@ def test_timestamp_datetimes_tz_aware(
         (any(x in str(constructor) for x in ("pyarrow",)) and is_windows())
         or ("pandas_pyarrow" in str(constructor) and PANDAS_VERSION < (2,))
         or ("pyarrow_table" in str(constructor) and PYARROW_VERSION < (12,))
-        or ("cudf" in str(constructor))
     ):
         request.applymarker(pytest.mark.xfail)
     if "pandas_pyarrow" in str(constructor) and PANDAS_VERSION < (

diff --git a/tests/translate/to_py_scalar_test.py b/tests/translate/to_py_scalar_test.py
@@ -29,8 +29,13 @@
     ],
 )
 def test_to_py_scalar(
-    constructor_eager: ConstructorEager, input_value: Any, expected: Any
+    constructor_eager: ConstructorEager,
+    input_value: Any,
+    expected: Any,
+    request: pytest.FixtureRequest,
 ) -> None:
+    if isinstance(input_value, bytes) and "cudf" in str(constructor_eager):
+        request.applymarker(pytest.mark.xfail)
     df = nw.from_native(constructor_eager({"a": [input_value]}))
     output = nw.to_py_scalar(df["a"].item(0))
     if expected == 1 and constructor_eager.__name__.startswith("pandas"):