forked from NVIDIA/spark-rapids
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add in checks for Parquet LEGACY date/time rebase (NVIDIA#435)
- Loading branch information
Showing
8 changed files
with
278 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
sql-plugin/src/main/scala/com/nvidia/spark/RebaseHelper.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Copyright (c) 2020, NVIDIA CORPORATION. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.nvidia.spark | ||
|
|
||
| import ai.rapids.cudf.{ColumnVector, DType, Scalar} | ||
| import com.nvidia.spark.rapids.Arm | ||
|
|
||
| import org.apache.spark.sql.catalyst.util.RebaseDateTime | ||
| import org.apache.spark.sql.internal.SQLConf | ||
| import org.apache.spark.sql.rapids.execution.TrampolineUtil | ||
|
|
||
| object RebaseHelper extends Arm { | ||
| private[this] def isDateTimeRebaseNeeded(column: ColumnVector, | ||
| startDay: Int, | ||
| startTs: Long): Boolean = { | ||
| val dtype = column.getType | ||
| if (dtype == DType.TIMESTAMP_DAYS) { | ||
| withResource(Scalar.timestampDaysFromInt(startDay)) { minGood => | ||
| withResource(column.lessThan(minGood)) { hasBad => | ||
| withResource(hasBad.any()) { a => | ||
| a.getBoolean | ||
| } | ||
| } | ||
| } | ||
| } else if (dtype.isTimestamp) { | ||
| assert(dtype == DType.TIMESTAMP_MICROSECONDS) | ||
| withResource( | ||
| Scalar.timestampFromLong(DType.TIMESTAMP_MICROSECONDS, startTs)) { minGood => | ||
| withResource(column.lessThan(minGood)) { hasBad => | ||
| withResource(hasBad.any()) { a => | ||
| a.getBoolean | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
|
|
||
| def isDateTimeRebaseNeededWrite(column: ColumnVector): Boolean = | ||
| isDateTimeRebaseNeeded(column, | ||
| RebaseDateTime.lastSwitchGregorianDay, | ||
| RebaseDateTime.lastSwitchGregorianTs) | ||
|
|
||
| def isDateTimeRebaseNeededRead(column: ColumnVector): Boolean = | ||
| isDateTimeRebaseNeeded(column, | ||
| RebaseDateTime.lastSwitchJulianDay, | ||
| RebaseDateTime.lastSwitchJulianTs) | ||
|
|
||
| def newRebaseExceptionInRead(format: String): Exception = { | ||
| val config = if (format == "Parquet") { | ||
| SQLConf.LEGACY_PARQUET_REBASE_MODE_IN_READ.key | ||
| } else if (format == "Avro") { | ||
| SQLConf.LEGACY_AVRO_REBASE_MODE_IN_READ.key | ||
| } else { | ||
| throw new IllegalStateException("unrecognized format " + format) | ||
| } | ||
| TrampolineUtil.makeSparkUpgradeException("3.0", | ||
| "reading dates before 1582-10-15 or timestamps before " + | ||
| s"1900-01-01T00:00:00Z from $format files can be ambiguous, as the files may be written by " + | ||
| "Spark 2.x or legacy versions of Hive, which uses a legacy hybrid calendar that is " + | ||
| "different from Spark 3.0+'s Proleptic Gregorian calendar. See more details in " + | ||
| s"SPARK-31404. The RAPIDS Accelerator does not support reading these 'LEGACY' files. To do " + | ||
| s"so you should disable $format support in the RAPIDS Accelerator " + | ||
| s"or set $config to 'CORRECTED' to read the datetime values as it is.", | ||
| null) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.