Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dependency tun that supports windows platform #2

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Update the dependency tun that supports windows platform #2

merged 4 commits into from
Nov 30, 2023

Conversation

xmh0511
Copy link
Contributor

@xmh0511 xmh0511 commented Nov 30, 2023

No description provided.

@SajjadPourali
Copy link
Collaborator

SajjadPourali commented Nov 30, 2023

Thanks for the PR.

I've noticed that the Windows implementation of the tun crate has some issues with its queuing mechanism, which causes a significant performance issue on Windows. Therefore, it would be preferable to retain the wintun example until this issue is resolved in tun.

I suggest to provide two different examples. one for tun.rs another one for wintun.rs

@SajjadPourali SajjadPourali merged commit 71ce18c into narrowlink:main Nov 30, 2023
@xmh0511
Copy link
Contributor Author

xmh0511 commented Dec 2, 2023

Thanks for the PR.

I've noticed that the Windows implementation of the tun crate has some issues with its queuing mechanism, which causes a significant performance issue on Windows. Therefore, it would be preferable to retain the wintun example until this issue is resolved in tun.

I suggest to provide two different examples. one for tun.rs another one for wintun.rs

Well, I see the issue. Waiting for this PR meh/rust-tun#74 to be merged, which uses a similar way you have given in wintun.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants