Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meeting Schedule] Calendar is broken #374

Closed
lmarcos opened this issue Nov 4, 2022 · 10 comments
Closed

[Meeting Schedule] Calendar is broken #374

lmarcos opened this issue Nov 4, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@lmarcos
Copy link

lmarcos commented Nov 4, 2022

🐛 Bug

Calendar page is broken

To Reproduce

Steps to reproduce the behavior:

  1. Go to Community -> Meeting Schedule
  2. Pay attention to calendar

Expected behavior

Calendar is overlapping text underneath

Environment

This is affecting versions 4..16 and 4.17 - MAC 13.0 Safari 16.1

image

@lauramarcos lauramarcos added the bug Something isn't working label Nov 4, 2022
@Czaki
Copy link
Contributor

Czaki commented Nov 4, 2022

On Ubuntu Firefox it works. Could you provide more details like OS and Browser?

@lauramarcos
Copy link

MAC 13.0 Safari 16.1 @Czaki

@melissawm
Copy link
Member

Is this related to napari/napari#371 or napari/napari#358?

@lauramarcos
Copy link

@melissawm this is related to #371

@melissawm
Copy link
Member

Ok - now that 0.4.17 is stable, the calendar appears there correctly: https://napari.org/stable/community/meeting_schedule.html

It will still be broken for 0.4.16, though, because I haven't backported the napari-sphinx-theme to that version of the docs. Do we want to go back and fix that too?

@psobolewskiPhD
Copy link
Member

IMO someone—like me—looking for the meeting calendar won't be poking around old versions? So it's not so crucial? Maybe better to implement a banner that informs the version is out-dated—I thought there was an issue for this, but can't find anywhere.

@melissawm
Copy link
Member

melissawm commented Nov 24, 2022

The discussion on the warning banner for the old docs is here napari/docs#82

I just updated with the latest from PyData Sphinx theme.

@psobolewskiPhD
Copy link
Member

So the 0.4.18 stable docs have the jumbled calendar again.
dev looks fine, as does 0.4.17
0.4.16 is broken as expected, but fine.
Any ideas @melissawm ? I assume something was missed in the porting of stuff back to napari/napari for the release.

@melissawm
Copy link
Member

Sorry yes, I will try to fix this soon

@melissawm
Copy link
Member

Fixed by #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants