Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to executed an action causes a TypeError with PySide2 #106

Closed
dalthviz opened this issue Sep 27, 2024 · 0 comments · Fixed by #107
Closed

Trying to executed an action causes a TypeError with PySide2 #106

dalthviz opened this issue Sep 27, 2024 · 0 comments · Fixed by #107
Assignees
@dalthviz

Comments

@dalthviz
Copy link
Member

Although after #104 the dialog is able to be launched when using PySide2, executing actions (install, uninstall, etc) raises a TypeError :/

  • Traceback:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File ~\AppData\Local\napari-0.5.4rc2\envs\napari-0.5.4rc2\lib\site-packages\napari_plugin_manager\qt_plugin_dialog.py:532, in PluginListItem._action_requested(self=<napari_plugin_manager.qt_plugin_dialog.PluginListItem(0x23ceb572450)>)
    526 tool = self.get_installer_tool()
    527 action = (
    528     InstallerActions.INSTALL
    529     if self.action_button.objectName() == 'install_button'
    530     else InstallerActions.UNINSTALL
    531 )
--> 532 self.actionRequested.emit(self.item, self.name, action, version, tool)
        version = ''
        tool = <InstallerTools.CONDA: 'conda'>
        action = <InstallerActions.UNINSTALL: 'uninstall'>
        self.item = <PySide2.QtWidgets.QListWidgetItem object at 0x0000023CEC48DB40>
        self.name = 'napari-ome-zarr'
        self = <napari_plugin_manager.qt_plugin_dialog.PluginListItem(0x23ceb572450) at 0x0000023CEC48D040>
        self.actionRequested = <PySide2.QtCore.SignalInstance object at 0x0000023CEC48F930>

TypeError: actionRequested() only accepts 0 argument(s), 5 given!

Checked with the https://github.com/napari/napari/releases/tag/v0.5.4rc2 Windows installer
@dalthviz dalthviz mentioned this issue Sep 27, 2024
Merged
@dalthviz dalthviz self-assigned this Sep 27, 2024
This was referenced Sep 27, 2024
Merged
Closed
jni added a commit to napari/napari that referenced this issue Sep 29, 2024
@dalthviz @jni
Remove skip conditions for PySide2/6 over plugins menu tests and bump…
d20a1fc 
… `napari-plugin-manager` minimum version (>=0.1.3) (#7293)

# References and relevant issues

Part of napari/napari-plugin-manager#94
Follow up for #7138

# Description

* Remove skip conditions related with `napari-plugin-manager` and PySide
issues
* Bump minimum `napari-plugin-manager` version constraint to >=0.1.2
(need for a new `napari-plugin-manager` release)
* Following the discovery of still having issues related with PySide2
compatibility that need to be addressed over napari-plugin-manager
(napari/napari-plugin-manager#106) update
requirement to 0.1.3 release and update the constraints

---------

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalthviz dalthviz

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dalthviz