-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bundled App Installation Instructions #74
Conversation
Adding images for the new bundled app installation instructions
Updating the bundled app installation instructions for MacOS, Windows, and Linux based on the new instructions for the latest bundled app release
Adding in @jaimergp suggestions and some other copy changes to the bundle installation guide
Keep existing installation.md, and rename the split installation_bundle.md as installation_bundle_conda.md. The existing installation.md covers the Briefcase installers.
Gentle reminder about this one @jaimergp Pretty high-value contribution!! |
I don't remember what was blocking this, but I think I recall it was something about conveying the right kind of messaging in the website. Are we ok to publish this now? @psobolewskiPhD Assuming we are, I think it would just need to update the screenshots so it shows 0.5.0 instead of 0.4.18-ish, and maybe polish some text here and there. Are we still pushing images directly in the git repo or is there another mechanism I should be aware of? |
@jaimergp I think the bundle was considered experimental? but now it's pretty stable, right? |
Hi all! Is there anything I can do to help push this forward? Cheers! 😄 |
Now that we have 0.5.x out, we can take the screenshots and update the text. |
@melissawm - do you happen to have a Linux (VM or not) machine for x64? I can only virtualize ARM 😬 |
@jaimergp yes I do, happy to help! |
Excellent, we'd just need to update the screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions work fine on Manjaro - do you need anything else? Updated screenshots of the viewer? For the terminal screenshots, I think the Ubuntu ones are more common tbh.
EDIT: Got it, will push to this PR in a few mins.
It's mostly about the version string in the screenshots. Having 0.5.0 looks cleaner than a dev version of 0.4.17 😬 I need to update the text too. I'll take a look at your suggestion, thanks! |
Let me know if you need something different! |
Looks amazing, thanks @melissawm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super!
Could we get it better integrated with the installation guide?
https://output.circle-artifacts.com/output/job/a8a5e740-214a-47ab-9c56-fed5228432a4/artifacts/0/docs/docs/_build/html/tutorials/fundamentals/installation.html#install-as-a-bundled-app
I think this should be all but dropped and just replaced with a link to the new guide?
@jaimergp we just discussed this at community meeting. At a minimum before merge we would like to add a link to this new guide in this page (source link). We are planning to release later today, so if you have a chance to add a small link 🙏 that would be great, otherwise, let us know and we can push directly. |
it looks good to me, thanks @jaimergp — I'm just gonna give @psobolewskiPhD a chance to have another look at it, but will just merge in the morning if he doesn't get a chance. |
comments were address by adding link in b322829
Sorry I dropped the ball on this -- long day 😞 |
all is well @psobolewskiPhD, I just hope I didn't offend you with 😂 🙏 |
Description
Add detailed installation instructions for the new conda-based bundled app, updated with screenshots from 0.5.0+.
References
Closes #67
This PR brings napari/napari#4383 over to
napari/docs
. It's not a perfect port, and I had to edit some patches, but it keeps most of the original history.Inspired by napari/napari#5240 (comment), I followed these steps:
napari/docs
:Sadly, the naive
git am
command with no flags didn't work, so I had to do it "interactively" with-i --rejected
, which iteratively creates*.rej
files with the rejected chunks of each patch: