-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.5.4 release notes #496
Conversation
@Czaki thanks for looking this over? If it looks ok now, could I get an approval? That way I can merge once I've checked the build, and tag the release candidate. 🙏 |
What did you think about napari/napari#7247 maybe add it to highlight? |
Gah... We are getting these errors on many of the gallery builds:
They seem like real bugs. Too late to debug here, will look in the morning, but if anyone has time to investigate today in other time zones, it would be much appreciated! 😅 🙏 I guess it comes from napari/napari#7269, but I guess we don't check for a no-warning docs build in the main repo? CC @dalthviz 🙏 |
I think that this PR needs to be merged #495. Just updated to trigger build with main of napari |
Yes, it looks like #495 solve the problem |
Hmmm still getting this failure: Traceback (most recent call last):
File "/home/circleci/project/napari/napari/_qt/qt_main_window.py", line 237, in set_status_and_tooltip
self._qt_viewer.viewer.status = status_and_tooltip[0]
File "/home/circleci/project/napari/napari/utils/events/evented_model.py", line 307, in __setattr__
with ComparisonDelayer(self):
File "/home/circleci/project/napari/napari/utils/events/evented_model.py", line 520, in __exit__
self._target._check_if_values_changed_and_emit_if_needed()
File "/home/circleci/project/napari/napari/utils/events/evented_model.py", line 345, in _check_if_values_changed_and_emit_if_needed
getattr(self.events, name)(value=new_value)
File "/home/circleci/project/napari/napari/utils/events/event.py", line 764, in __call__
self._invoke_callback(cb, event if pass_event else None)
File "/home/circleci/project/napari/napari/utils/events/event.py", line 802, in _invoke_callback
_handle_exception(
File "/home/circleci/project/napari/napari/utils/events/event.py", line 789, in _invoke_callback
cb(event)
File "/home/circleci/project/napari/napari/_qt/qt_main_window.py", line 1572, in _status_changed
self._status_bar.setStatusText(event.value)
File "/home/circleci/project/napari/napari/_qt/qt_main_window.py", line 857, in _status_bar
return self._qt_window.statusBar()
AttributeError: 'Window' object has no attribute '_qt_window' which does look like a genuine napari bug. |
Ok what. It was just the toc missing. That is a weird manifestation of the missing toc LOL. |
No description provided.