Update app-model doc with new information about _mock_app fixture
#403
Conversation
github-actions
bot
added
the
documentation
| of every test. | ||
| Since the `_mock_app` fixture is used in `make_napari_viewer`, plugins and other | ||
| external users that write tests using `make_napari_viewer` will also have the benefit | ||
| of a new app for each test. |
There was a problem hiding this comment.
Should we mention that it is exported just like make_napari_viewer so envs with napari installed will be able to use these fixtures? We do mention this when we talk about make_napari_viewer: https://napari.org/dev/developers/contributing/testing.html#make-napari-viewer
(ignore the failed include, I think thats fixed in #393)
There was a problem hiding this comment.
I thought about it but since we've kept it private (kinda with the underscore), I'd rather not mention it explicitly as I don't necessarily want to encourage direct usage of it by external packages. If we find use for it I'd be happy to amend then.
There was a problem hiding this comment.
Gotcha, good point.
Slightly related. could we add a link to the make_napari_viewer, maybe further up, when we first mention it?
References and relevant issues
Depends on napari/#6823
Description
Updates the information about
_mock_appto state that we use it explicitly in_make_napari_viewerand allother tests that require a
NapariApplication.Also make note that plugins that use
make_napari_viewernow get the benefit of the_mock_app.