Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about autogeneration of plugin docs #395

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

melissawm
Copy link
Member

References and relevant issues

Closes #391

Description

Adds a note about how the plugin docs are generated from npe2 templates through the prep_docs.py script.

@melissawm melissawm requested a review from lucyleeow April 7, 2024 00:23
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 7, 2024
@melissawm
Copy link
Member Author

Not sure if this is the best place, but it seemed like it. Also happy to reword if this is not clear!

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Apr 7, 2024
Copy link
Collaborator

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some more clarifications for newbies 🙏 Thank you!


Some of the source files for the [Plugin documentation](plugins-index) are
autogenerated from sources in the [napari/npe2](https://github.com/napari/npe2)
repository. These files' names start with an underscore `_` and will be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an example, "e.g., _npe2_contributions.md"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even add that these added files all live in docs/plugins/ (I think this is right?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant to mention filenames and location because these may change and keeping this document up-to-date may be difficult (for example we recently moved a bunch of files under the plugins folder). But I think mentioning they are under "plugins" is reasonable indeed.

docs/developers/contributing/documentation/index.md Outdated Show resolved Hide resolved
docs/developers/contributing/documentation/index.md Outdated Show resolved Hide resolved
@melissawm
Copy link
Member Author

Let me know if this is better, if it's still confusing I'm happy to reword!

Copy link
Collaborator

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@psobolewskiPhD psobolewskiPhD merged commit 88cab81 into napari:main Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info on how plugin docs from npe2 are deployed
3 participants