Update packaging guide by removing outdated constructor fork details
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
jaimergp
changed the title
constructor fork details
|
This maybe should only be merged once we land napari/packaging#103. |
psobolewskiPhD
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Looks good! Small nitpick:
For construct.yaml docs link, can you switch to the rendered docs site:
https://conda.github.io/constructor/construct-yaml/
Also I think you can clear out most of the hyperlinks at the bottom of the file.
|
Well, this is ready for merge now @psobolewskiPhD 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Comes from napari/packaging#15 (comment).
Depends on napari/packaging#103.
Description
This updates the Packaging docs to remove the (soon) outdated details about our constructor stack fork. I also took the opportunity to adjust some sentences that were a bit ambiguous.