Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of magicgui guide #314

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

melissawm
Copy link
Member

Description

Fixes a typo that generates an error while building the docs.

@melissawm melissawm added the bug Something isn't working label Jan 8, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2024
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Took me a while to figure out how you found that: lots of scrolling and then finally I located the traceback in the Artifacts tab here, for future reference:
https://app.circleci.com/pipelines/github/napari/docs/473/workflows/9c1f028d-4f26-4f66-98aa-2eb3122db758/jobs/463/steps?invite=true#step-106-78540_93

@melissawm
Copy link
Member Author

I'm working on reducing the number of errors so we don't miss those anymore!

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Jan 8, 2024
@psobolewskiPhD psobolewskiPhD merged commit 27671ea into napari:main Jan 13, 2024
6 checks passed
psobolewskiPhD pushed a commit that referenced this pull request Feb 14, 2024
# Description
This error was first fixed in #314 but undone in
#286 - probably due to a conflict
that wasn't flagged because of the files moving around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants