Telemetry: Add sample code for collecting data and sample outputs #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Czaki
changed the title
There was a problem hiding this comment.
Just left some suggestions for expanding the text a bit and a few nit comments. Thanks for the detailed sample @Czaki, I think having this info should make it much easier for folks to assess how they feel about the proposed level of telemetry.
| data_collector = DataSizeTypeCollector.get_collector( | ||
| Path(appdirs.user_config_dir("napari")) / "data_size_info.json" | ||
| ) | ||
| # app_model = get_app() - there is a need to add a collection of data to app_model |
There was a problem hiding this comment.
I'm not sure what you mean here or if it needs to be removed?
There was a problem hiding this comment.
Ahh I think based on your comment below you mean we need to add a log option to app-model so that we can access a history of commands? Maybe just expand a bit on that.
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com>
jni
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on previous discussion, this PR contains sample code how we could collect data and how a report for telemetry could look.