Fix pydantic import #255
Merged
Fix pydantic import #255
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses napari pydantic compatibility shim.
github-actions
bot
added
the
documentation
psobolewskiPhD
approved these changes
Oct 27, 2023
|
I think this needs to be ported to 0.4.19 branch so I tagged it. But maybe I'm wrong because 0.4.19 docs build from main repo? CC: @Czaki |
|
This PR is only required for the simplification of the build of docs locally. For CI it is fixed by #251 |
psobolewskiPhD
added a commit
that referenced
this pull request
Dec 1, 2023
# References and relevant issues Closes napari/napari#6392 Depends on #255 # Description Added a sphinx gallery option to fail the docs build on example execution failure. Right now, this _should_ fail on CI due to one of our example failing, but the docs build will anyway depend on the #255. Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes #254
Description
Uses napari pydantic compatibility shim in
update_preference_docs.py.