-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Minor fixes to nap 6 doc #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @lucyleeow just small change requests - one to make it clear that the layer right click menu is already open, and the other to remove the Plugins
top level menu as that won't be open - only the plugin's own submenu within there.
docs/naps/6-contributable-menus.md
Outdated
@@ -238,6 +238,9 @@ Layers | |||
│ ├─ Tracks | |||
│ ├─ Classification | |||
Acquisition | |||
Plugins | |||
|
|||
Layers context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layers context | |
Layers Context # already open for contribution |
docs/naps/6-contributable-menus.md
Outdated
@@ -238,6 +238,9 @@ Layers | |||
│ ├─ Tracks | |||
│ ├─ Classification | |||
Acquisition | |||
Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add this here as the Plugins
menu itself is not open for contribution - only the individual plugin's menu within there would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, what about expanding to:
Plugins/<my_plugin> # only individual plugins submenu contributable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep @lucyleeow that works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucyleeow, LGTM!
Is this okay to go in? @DragaDoncila |
@lucyleeow thanks for the ping! Done |
Description
npe2
codeLayer
would be a top level menucc @DragaDoncila
Type of change
References
Final checklist: