Add huge_tree as an optional_arg in junos to fix xml huge tree node #2012 #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mirceaulinic
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Looks good. Thanks for this @architkhatri98 and sorry for the delayed review!
Would you mind documenting this new optional arg at https://github.com/napalm-automation/napalm/blob/develop/docs/support/index.rst?plain=1 (under the List of supported optional arguments section).
|
Mergin and I'll follow up with a PR to add the documentation. |
mirceaulinic
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will solve issue #2012 by adding
huge_treeas an optional arg and sending it tojnpr.junos.device.Device()Juniper/py-junos-eznc#975