Closes #2005: Change rollback behavior #2006
Conversation
decoupca
force-pushed
the
2005-change-rollback-behavior
branch
from
d6c5609
to
5e4f948
Compare
|
Related issue and discussion: |
|
@decoupca Is there a separate change for Cisco IOS? |
No, sounded like we wanted to make the changes in one pass but I can separate it out if you like. |
| self.changed = False | ||
| if not self._check_file_exists(cfg_file=self.rollback_cfg): | ||
| msg = f"Rollback file '{self.rollback_cfg}' does not exist on device." | ||
| raise ReplaceConfigException(msg) |
There was a problem hiding this comment.
This might not be the right exception i.e. what are the cases where rollback gets called. We probably need to look at that a bit more. I generally view a ReplaceConfigException as an exception you get when you try to do the replace config operation.
I guess we could raise a generic NapalmException
There was a problem hiding this comment.
I copied ReplaceConfigException from other code that raises that exception during a rollback. I thought about raising NapalmException or creating a new RollbackConfigException, but I don't have strong preferences here.
There was a problem hiding this comment.
Okay, let me look some more. I only looked at it quickly (it could make the most sense given what we have previously done).
|
@decoupca There aren't any IOS changes in this pull-request though? Was there another file/change that needed included? |
Oh my mistake -- I didn't change anything, that check was already built in to the IOS driver. Only NXOS and NXOS_SSH have changed to match the IOS/JUNOS behavior. |
|
No worries...I just misunderstood (didn't check) what you had mentioned above. |
Changes rollback behavior so that calling
rollback()attempts to roll back to the most recent config snapshot, regardless of whether napalm is aware of making any changes in the current session. For platforms that use file-based snapshots, ensures the rollback file exists on the remote system before attempting rollback.JUNOS, IOSXR and EOS all behaved this way before this PR -- no changes made.
IOS: added check to ensure rollback file exists before attempting.IOS already has a file exists check in place for rollbacksNXOS and NXOS-SSH: Removed check that prevented rollbacks if napalm is not aware of changes made. Also implemented
_check_file_existsand added checks to ensurerollback_cfgexists prior to rollback attempt.