Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) #1754

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

jtishey
Copy link
Contributor

@jtishey jtishey commented Sep 14, 2022

Getting errors on BGP neighbors with a cluster IP seem to be causing an exception to be raised in helpers.convert()

Please see issue #1753 for more info.

@jtishey
Copy link
Contributor Author

jtishey commented Sep 15, 2022

Tests were failing because adding a default data type for cluster was adding it as a key to the outgoing data, which isn't what we want. So I undid that and changed it to be ignored when the key/values are being standardized and added to the outgoing bgp_config dict.

@jtishey jtishey changed the title JUNOS get_bgp_config() - Add default datatype for cluster (Fix #1753) JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) Sep 27, 2022
@jtishey
Copy link
Contributor Author

jtishey commented Sep 29, 2022

Ran into a similar issue with the multihop key on some groups. Still looking to see why and if there's a better way to account for these.

@jtishey jtishey changed the title JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) Draft: JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) Sep 29, 2022
@jtishey
Copy link
Contributor Author

jtishey commented Oct 21, 2022

I think skipping the bgp_config + convert should be ok since it should have a datatype for all of the fields it cares about. Let me know if that's not the case.

@jtishey jtishey changed the title Draft: JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) JUNOS get_bgp_config() - ValueError: Can't convert with callable None (Fix #1753) Oct 21, 2022
@mirceaulinic mirceaulinic merged commit 3d411b0 into napalm-automation:develop Mar 21, 2024
6 checks passed
@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants