Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7 support #1

Merged
merged 3 commits into from
Jul 21, 2015
Merged

0.7 support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0c4a96
Change main script to index.ios.js
Jul 4, 2015
102b6f2
Don't depend on react-native internal modules
Jul 4, 2015
b6d3d85
Remove unused require
Jul 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 SafariViewManager.android.js → index.android.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions SafariViewManager.ios.js → index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
*/
'use strict';

var NativeSafariViewManager = require('NativeModules').SafariViewManager;
var invariant = require('invariant');
var NativeModules = require('react-native').NativeModules;
var NativeSafariViewManager = NativeModules.SafariViewManager;

/**
* High-level docs for the SafariViewManager iOS API can be written here.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "react-native-safari-view",
"version": "0.1.0",
"description": "A React Native wrapper for Safari View Controller",
"main": "SafariViewMananger.ios.js",
"main": "index.ios.js",
"scripts": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird to me, since the repo doesn't have an index.ios.js file.

After reading the issue you liked to, it seems more like a react-native bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has - I renamed SafariViewManager.ios.js in the PR as index.ios.js.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I missed that. 😁

I'd still like to wait for the outcome of facebook/react-native#1808 prior to renaming the ios.js file.

I'd rather the file names remain consistent with the way react-native new-library structures libraries.

"test": "echo \"Error: no test specified\" && exit 1"
},
Expand Down