Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests #151

Merged
merged 2 commits into from
Jul 19, 2024
Merged

add unit tests #151

merged 2 commits into from
Jul 19, 2024

Conversation

samjhill
Copy link
Contributor

Thank you for doing great work for the Fediverse! I figured I'd try and give back a little to show my support.

This PR adds unit tests and a Github action to run them automatically on pull request and merge to main. The coverage report is saved as an artifact on each run for later reference.

I welcome any feedback on the tests and am open to suggestions for additional coverage or improvements.

All tests are designed to be non-intrusive and maintain the integrity of the existing codebase.

@nanos
Copy link
Owner

nanos commented Jul 19, 2024

Love it! Thanks @samjhill

However, could address these please? I know they aren't critical at this stage, but I'd like to start with a clean slate, please.

image

Thanks!

@samjhill
Copy link
Contributor Author

absolutely! I've updated the workflow action versions and specified the python version. Let me know what you think!

@nanos
Copy link
Owner

nanos commented Jul 19, 2024

Amazing. Thank you!

@nanos nanos merged commit c09e192 into nanos:main Jul 19, 2024
1 check passed
@samjhill samjhill deleted the feature/tests branch July 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants