Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1713 SP pipe_send leaks message if aio is canceled #1715

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 26, 2023

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (003f055) 79.37% compared to head (759a2e9) 79.07%.

Files Patch % Lines
src/sp/transport/inproc/inproc.c 0.00% 2 Missing ⚠️
src/sp/transport/ipc/ipc.c 0.00% 2 Missing ⚠️
src/sp/transport/tcp/tcp.c 0.00% 2 Missing ⚠️
src/sp/transport/tls/tls.c 0.00% 2 Missing ⚠️
src/sp/transport/ws/websocket.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   79.37%   79.07%   -0.31%     
==========================================
  Files          89       89              
  Lines       20244    20254      +10     
==========================================
- Hits        16069    16015      -54     
- Misses       4175     4239      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 759a2e9 into master Nov 26, 2023
16 of 18 checks passed
@gdamore
Copy link
Contributor Author

gdamore commented Nov 26, 2023

Waiving the coverage exception -- testing that case is rather challenging, and would really require writing a test transport framework, which is more effort than I want to spend on right now.

@gdamore gdamore deleted the gdamore/pipe_send_leak branch November 26, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant