Normalize ifdef macro handlings for configs #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places, we use ifdef, and others if. This normalizes for always using ifdef, so we can compile when this macro is not defined.
In some places, we use ifdef, and others if. This normalizes for always using ifdef, so we can compile when this macro is not defined.
In some places, we use ifdef, and others if. This normalizes for always using ifdef, so we can compile when this macro is not defined.
gdamore
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes warnings or build error when macros are undefined or set to
0When they are set to
0, nng does not even build due to undefined references.When they are unset, we get many warnings, like:
This fixes by using
ifdefeverywhere, so we don't get any warnings when the macros are not set.Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.