Update win_tcpconn.c

[NissimBendanan]

fixes #1676 nanomsg does not compile using clang version 16.0.5

[shikokuchuo]

@gdamore I've been running with this change and good to merge from my perspective.

[NissimBendanan]

got the following timeout error, is it OK for you? or someone can re trigger the tests? what next steps to merge this PR?
Thanks
Nissim

46/80 Test #46: nng.ipc .....................................***Timeout 5.53 sec === RUN: IPC Transport

[gdamore]

I've been stalling on this because I'm not actually sure this change is "correct" -- I get that it makes the code compile, but it may be more correct to match the types elsewhere. I will try to examine more closely soon.

[NissimBendanan]

Hi, In nni_win_tcp_init, all handlers (apart tcp_recv) use the same “type of” signature that get as first argument a void pointer and then cast the arg to nni_tcp_conn *c: c->ops.s_close = tcp_close; c->ops.s_free = tcp_free; c->ops.s_send = tcp_send; c->ops.s_recv = tcp_recv; c->ops.s_get = tcp_get; c->ops.s_set = tcp_set; struct nng_stream { void (*s_free)(void *); void (*s_close)(void *); void (*s_recv)(void *, nng_aio *); void (*s_send)(void *, nng_aio *); int (*s_get)(void *, const char *, void *, size_t *, nni_type); int (*s_set)(void *, const char *, const void *, size_t, nni_type); }; For tcp_recv, the original signature didn’t follow the declaration of struct nng_stream{ s_recv }. The last version of clang exit with error on this mismatch. Can you please check? Thanks Nissim

[gdamore]

Checked, finally. Sorry for the delay. Thanks for the submission.