Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in SSL accept handler #62

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Improvements in SSL accept handler #62

merged 1 commit into from
Nov 12, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 12, 2019 •
edited
Loading

Description

  • Replace sslProtocols collection with parameter.
  • Replace call to AuthenticateAsServer to remove requirement for client certificate.
  • Lock object is now initialized in constructor.
  • Correct typos in comments.
  • Bump version to 1.2.2-preview.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Nov 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the improvements-ssl-accept branch from 08b3b52 to a49b6cf Compare November 12, 2019 20:22
@josesimoes
Improvements in SSL accept handler
7a5a4e4 
- Replace sslProtocols collection with parameter.
- Replace call to AuthenticateAsServer to remove requirement for client certificate.
- Lock object is now initialized in constructor.
- Correct typos in comments.
- Bump version to 1.2.2-preview.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the improvements-ssl-accept branch from a49b6cf to 7a5a4e4 Compare November 12, 2019 21:55
@josesimoes
Copy link
Member Author

Ignoring Sonarcloud complexity error.

@josesimoes josesimoes merged commit 90366e3 into nanoframework:develop Nov 12, 2019
@josesimoes josesimoes deleted the improvements-ssl-accept branch November 12, 2019 22:06
This was referenced Dec 16, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI: Publish Release Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot