Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SslProtocol property to allow selecting it #24

Merged
merged 11 commits into from
Apr 5, 2019
Merged

Add SslProtocol property to allow selecting it #24

merged 11 commits into from
Apr 5, 2019

Conversation

RoSchmiSec
Copy link
Contributor

@RoSchmiSec RoSchmiSec commented Apr 4, 2019

Up to now SSL 3.0 or TLS 1.0 were used as default SslProtocols.
Now default SslProtocol is .None.
Users are forced to actively select the wanted SslProtocol bei setting the new 'SslProtocolToUse' property

Closes nanoframework/Home#473.

@nfbot
Copy link
Member

nfbot commented Apr 4, 2019

Hi @RoSchmiSec,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

All three projects should use the same packages.config otherwise the automated dependencies update won't work.
All three projects should use the same packages.config otherwise the automated dependencies update won't work.
- No need to use the specific version here.
- No need to use the specific version here.
- No need to use the specific version here.
- Change property name to follow .NET API.
- Change property name to follow .NET API.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolving nanoframework/Home#473.
Thanks for taking care of it.

@josesimoes josesimoes changed the title Set default SslProtocol for https to .None. Implement SslProtocolToUse property to select SslProtocol Add SslProtocol property to allow selecting it Apr 4, 2019
@josesimoes josesimoes merged commit 7260940 into nanoframework:develop Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants