Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NetworkHelper.cs #147

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Update NetworkHelper.cs #147

merged 3 commits into from
Oct 18, 2021

Conversation

AlirezaP
Copy link
Contributor

Description

This Bug Case Wifi Always be in "isAlreadyConnected" mode!!!

Motivation and Context

  • Fixes

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 12, 2021

Hi @AlirezaP,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added the Type: bug Something isn't working label Sep 12, 2021
@josesimoes josesimoes enabled auto-merge (squash) September 12, 2021 17:50
@josesimoes josesimoes disabled auto-merge September 12, 2021 17:51
@josesimoes josesimoes enabled auto-merge (squash) September 12, 2021 17:52
@josesimoes
Copy link
Member

@Ellerbach can you please review this? It's waiting for a while... 😉

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry, totally missed that one :-(

@josesimoes josesimoes merged commit 02bba0b into nanoframework:develop Oct 18, 2021
@nfbot
Copy link
Member

nfbot commented Oct 18, 2021

@AlirezaP thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/AlirezaP.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/AlirezaP">Alireza Paridar</a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants