Fix out of order ledger notifications #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
ledger-notifications-3
branch
from
ee47806 to
5ed3aab
Compare
Test Results for Commit 5ed3aabPull Request 4824: Results Test Case Results
Last updated: 2025-01-14 22:58:48 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with bootstrap stalls when bounded backlog is enabled.
We issue ledger notifications on a separate background thread for performance reasons to avoid unnecessary work on threads that perform ledger writes. Because of this both block processor and bounded backlog classes modify ledger and issue their notifications from their own background workers, which will as currently implemented will lead to some strange interleavings.
This implements a component that manages a single thread that issues ledger modification notifications in the same exact order they were performed.