Networking cleanup continued #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
networking-fixes-tcp-channels
branch
from
82e92cd to
8bfb8af
Compare
pwojcikdev
force-pushed
the
networking-fixes-tcp-channels
branch
from
d25037a to
0d61dba
Compare
clemahieu
approved these changes
Mar 17, 2024
nano/node/transport/tcp.cpp
Outdated
| nano::unique_lock<nano::mutex> lock{ mutex }; | ||
| while (!stopped) | ||
| { | ||
| condition.wait_for (lock, node.network_params.network.keepalive_period); |
There was a problem hiding this comment.
It probably doesn't make much of a difference but wait_for can spurriously wake up.
There was a problem hiding this comment.
It's a good point. Here I wanted something that works and is simple to implement. It should be trivial to implement a helper that ensures the interval is always respected. Adding this to my todo list.
| @@ -55,7 +55,7 @@ namespace transport | |||
| class tcp_server; | |||
| class tcp_channels; | |||
|
|
|||
| class channel_tcp : public nano::transport::channel | |||
| class channel_tcp : public nano::transport::channel, public std::enable_shared_from_this<channel_tcp> | |||
There was a problem hiding this comment.
Maybe enable_shared_from_this should be on the base class nano::transport::channel?
There was a problem hiding this comment.
I'm not aware of an easy way to get shared_from_this working with a base class, is there any? From what I understand a form of CRTP pattern will be needed, is this the best way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on cleanup of
tcp_channelsclass. It eliminates some obvious inefficiencies (theupdatefunction), offloads peer reachout loop to a dedicated thread and fixes shutdown bug.