Fix rpc receivable unconfirmed and rpc.accounts_receivable_confirmed #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RPC speak, cofnirmed is equivalent to cemented and in this case the test only check if the election is not active, which indirectly but not directly implies that the election is confirmed. But even then it is not necesarily cemented since that is an extra background step. We should check for cemented with the function nano::test:confirmed(), which is also confusing...
dsiganos
added
unit test
clemahieu
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were indirectly checking for confirmed rather than directly checking for cemented status.
So there was a race condition where a block could be confirmed but not cemented.