During release process, create pull request to increment major version on instead of a direct commit #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2024 10:00
… commit - develop branch is protected, so the workflow create a PR instead of a direct commit
dsiganos
previously approved these changes
Jan 22, 2024
| git reset --hard HEAD~1 | ||
| git push origin $NEW_BRANCH | ||
| # Create pull request | ||
| export GH_TOKEN=${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Is it safe to put the GitHub token in an enviroment variable? I don't know if it is or isn't just asking the question.
There was a problem hiding this comment.
In this case it should be safe as it never leaves the workflow.
Its validity is limited to the duration and the scope of the current workflow. (It's not a PAT)
Also its not passed to an external script but required for gh pr create
|
LGTM but @clemahieu should really review it too since he is more familiar now with the release process than I am. |
- reset local changes made to MAJOR_VERSION before pushing to releases
|
Just noticed that I dropped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of directly trying to commit to the protected develop branch, we can create a pull request with the version increment like this : gr0vity-dev#9 which can then be merged after the workflow has ended.