Make node_telemetry.dos_udp more robust under tsan #2639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed it doesn't seem to be an issue anymore. Tested a TSAN run with 50 iterations with #2669 to make sure it wouldn't break anything too in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to spin on some stat checks, as it otherwise fails intermittently under tsan. I used the opportunity to switch the test to ASSERT_TIMELY etc to reduce line count.
It's quite sensitive to timing, so I also had to do the
- 1sthing, otherwise it occasionally hangs forever; maybe there's a better way.