Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Election refactor follow up #2619

Merged
merged 8 commits into from
Mar 4, 2020
Merged

Election refactor follow up #2619

merged 8 commits into from
Mar 4, 2020

Commits on Mar 2, 2020

  1. active_transactions include cleanup

    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    244f3ae View commit details
    Browse the repository at this point in the history

  2. Allocate a new solicitor on every confirmation request loop

    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    b851974 View commit details
    Browse the repository at this point in the history

  3. Increment election confirmation_request_count 

    This was accidentally erased in the refactor and there was no test to ensure it. One test removed as it was not testing the intended functionality. Other tests were updated to ensure confirmation_request_count is incremented. It was necessary to disable the rep crawler to properly test the confirmation loop.
    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    18b6bf0 View commit details
    Browse the repository at this point in the history

  4. Ensuring confirmed elections are not returned in RPC confirmation_info

    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    f684f03 View commit details
    Browse the repository at this point in the history

  5. Adding information on confirmed blocks for RPC confirmation_active

    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    0732da0 View commit details
    Browse the repository at this point in the history

  6. Moving election status definitions to secure/common

    @guilhermelawless
    guilhermelawless committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    de8d66e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Re-lock after activating dependencies (bug found by @cryptocode) 

    Otherwise, could call state_change to `expired_unconfirmed` without owning the mutex
    @guilhermelawless
    guilhermelawless authored Mar 4, 2020
    Configuration menu
    Copy the full SHA
    9787531 View commit details
    Browse the repository at this point in the history

  2. Enhance node.activate_dependencies test by ensuring full confirmation… 

    … (Serg review)
    @guilhermelawless
    guilhermelawless committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    cc7add9 View commit details
    Browse the repository at this point in the history