Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bind to UDP socket with --disable_udp flag #2464

Merged
merged 11 commits into from
Jan 20, 2020
Merged

Don't bind to UDP socket with --disable_udp flag #2464

merged 11 commits into from
Jan 20, 2020

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Jan 9, 2020

  • don't bind to UDP socket with --disable_udp flag
  • don't start port mapping with both UDP & TCP sockets disabled
  • use predefined port in nano::network::endpoint () function rather than call to UDP socket
  • update TCP (bootstrap) server endpoint () function to return empty endpoint if server is not started
  • update several tests to run twice: with UDP only and with TCP only
  • attepmt to start realtime TCP connection to RPC bootstrap peer if UDP is disabled

@SergiySW SergiySW added this to the V21.0 milestone Jan 9, 2020
@SergiySW SergiySW self-assigned this Jan 9, 2020
cryptocode
cryptocode previously approved these changes Jan 10, 2020
View reviewed changes
wezrule
wezrule suggested changes Jan 14, 2020
View reviewed changes
nano/node/transport/udp.hpp Outdated Show resolved Hide resolved
cryptocode
cryptocode previously approved these changes Jan 17, 2020
View reviewed changes
@SergiySW SergiySW requested a review from wezrule January 20, 2020 15:17
wezrule
wezrule previously approved these changes Jan 20, 2020
View reviewed changes
@SergiySW SergiySW dismissed stale reviews from wezrule and cryptocode via 80df6f9 January 20, 2020 15:24
@SergiySW SergiySW merged commit e9aae5c into nanocurrency:develop Jan 20, 2020
@zhyatt zhyatt added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
networking quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @wezrule @cryptocode @zhyatt