Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy bootstrap memory usage improvements #2385

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Lazy bootstrap memory usage improvements #2385

merged 3 commits into from
Nov 7, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Nov 4, 2019 •
edited
Loading

  • Limit bulk pulls memory usage in lazy bootstrap, flush less pulls from lazy_pulls to pulls
  • Limit max lazy bootstrap blocks size if legacy bootstrap is enabled (1M lazy blocks limit)
  • Prevent lazy destinations usage if legacy bootstrap is enabled

Better to check with hidden whitespace changes

@SergiySW SergiySW added this to the V20.0 milestone Nov 4, 2019
@SergiySW SergiySW self-assigned this Nov 4, 2019
@SergiySW SergiySW force-pushed the bootstrap/lazy_memory_usage_improvements branch from adab49b to f1cd129 Compare November 5, 2019 00:19
wezrule
wezrule reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing a Debug ASAN build bootstrap with --disable_legacy_bootstrap, currently @7m unchecked blocks. No problems yet

nano/node/bootstrap/bootstrap.cpp Outdated Show resolved Hide resolved
nano/node/bootstrap/bootstrap.cpp Outdated Show resolved Hide resolved
nano/node/bootstrap/bootstrap.cpp Outdated Show resolved Hide resolved
@SergiySW SergiySW force-pushed the bootstrap/lazy_memory_usage_improvements branch from f1cd129 to 5f6b8f6 Compare November 5, 2019 15:58
@SergiySW SergiySW force-pushed the bootstrap/lazy_memory_usage_improvements branch from 5f6b8f6 to ca519c0 Compare November 5, 2019 17:52
wezrule
wezrule approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4M checked, 19M unchecked currently in my run, looking good so far.

@SergiySW SergiySW force-pushed the bootstrap/lazy_memory_usage_improvements branch 2 times, most recently from 577b914 to 7a503fe Compare November 7, 2019 15:10
@SergiySW SergiySW merged commit 3a3c56a into nanocurrency:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@argakiig argakiig argakiig approved these changes

@guilhermelawless guilhermelawless guilhermelawless approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
enhancement
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SergiySW @wezrule @argakiig @guilhermelawless @cryptocode