Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI --debug_validate_blocks enhancement #2269

Merged
merged 3 commits into from
Sep 2, 2019
Merged

CLI --debug_validate_blocks enhancement #2269

merged 3 commits into from
Sep 2, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Sep 1, 2019 •
edited
Loading

  • validate representative block
  • check type & previous field for open blocks
  • check if successor block exists instead of segfault
  • validate total block count

@SergiySW
CLI --debug_validate_blocks enhancement
ca2097a 
- validate representative block
- check type & previous field for open blocks
@SergiySW SergiySW added this to the V20.0 milestone Sep 1, 2019
@SergiySW SergiySW self-assigned this Sep 1, 2019
guilhermelawless
guilhermelawless suggested changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be conservative and check that the block exists, outputting an error if not. L836

@guilhermelawless guilhermelawless merged commit 02765ed into nanocurrency:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@guilhermelawless guilhermelawless guilhermelawless approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
enhancement
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @wezrule @guilhermelawless @cryptocode