Distributed work refactor #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a factory that also saves distributed work objects and a work cancel observer, work can now be properly cancelled to work peers
guilhermelawless
added
the
quality improvements
|
Most of the apparent changes are simply extracting Tests added. |
cryptocode
approved these changes
Aug 28, 2019
wezrule
reviewed
Aug 29, 2019
wezrule
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing:
Work can now be properly cancelled across local generation and work peers, simply by using the observer.
work_generatenow takes an optional so the caller may choose to handle work cancellation (work not set once callback was fired)