Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node_ prefix for node ID #2191

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Use node_ prefix for node ID #2191

merged 3 commits into from
Aug 5, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Aug 3, 2019

@SergiySW SergiySW added this to the V20.0 milestone Aug 3, 2019
@SergiySW SergiySW self-assigned this Aug 3, 2019
@cryptocode cryptocode added the documentation This item indicates the need for or supplies updated or expanded documentation label Aug 3, 2019
cryptocode
cryptocode reviewed Aug 3, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the RPC doc update, maybe as_account should be deprecated?

nano/node/json_handler.cpp Outdated Show resolved Hide resolved
SergiySW added a commit to SergiySW/nano-docs that referenced this pull request Aug 3, 2019
@SergiySW
Use node_ prefix for node ID
42eb2c4 
nanocurrency/nano-node#2191
@SergiySW SergiySW mentioned this pull request Aug 3, 2019
Merged
zhyatt pushed a commit to nanocurrency/nano-docs that referenced this pull request Aug 5, 2019
@SergiySW @zhyatt
Use node_ prefix for node ID (#67)
90c60d0 
* Use node_ prefix for node ID

nanocurrency/nano-node#2191

* Minor typo

* Clarify versions using node_ prefix
@SergiySW SergiySW merged commit 83e5c50 into nanocurrency:master Aug 5, 2019
@SergiySW SergiySW mentioned this pull request Aug 5, 2019
Merged
GuyWhoKnowsTheGuy pushed a commit to GuyWhoKnowsTheGuy/nano-docs that referenced this pull request Aug 9, 2019
@SergiySW @GuyWhoKnowsTheGuy
Use node_ prefix for node ID (nanocurrency#67)
1711194 
* Use node_ prefix for node ID

nanocurrency/nano-node#2191

* Minor typo

* Clarify versions using node_ prefix
@zhyatt zhyatt mentioned this pull request Oct 14, 2019
Closed
@zhyatt zhyatt added rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. and removed rpc semantics change labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted.
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @argakiig @cryptocode @zhyatt